Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start on the 5.9 Sendable issues #1461

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Start on the 5.9 Sendable issues #1461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aad376
Move from a `var` to a `let` to help silence some 5.9 Sendable warnings.
thomasvl Sep 20, 2023
9e2b702
Change the test error to a struct to avoid Sendable issues with 5.9.
thomasvl Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SwiftProtobuf/Google_Protobuf_Any+Registry.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import Foundation
#if !os(WASI)
#if canImport(Dispatch)
import Dispatch
fileprivate var knownTypesQueue =
fileprivate let knownTypesQueue =
DispatchQueue(label: "org.swift.protobuf.typeRegistry",
attributes: .concurrent)
#endif
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftProtobufTests/Test_AllTypes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2583,7 +2583,7 @@ class Test_AllTypes: XCTestCase, PBTestHelpers {
}

func testWithFactoryHelperRethrows() {
class TestWithFactoryHelperRethrows_Error : Error {}
struct TestWithFactoryHelperRethrows_Error : Error {}

let pNoThrow: (inout SwiftProtoTesting_ForeignMessage) -> () = { $0.c = 1 }
let m1 = SwiftProtoTesting_ForeignMessage.with(pNoThrow)
Expand Down