Fix Foundation import's access level in generated code #1701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1683 added support for access level modifiers on imports in the generated code.
Foundation
(which is needed becauseData
is used extensively in generated protos) is imported by manually writing to the file instead of using the "compute imports" logic we use to deal with all other imports. This is because other imports are all imports coming from other generated proto files, whereas Foundation is "pure Swift" dependency.We forgot to add the access level modifier to this
Foundation
import.This causes issues when enabling the
InternalImportsByDefault
flag on modules that use generated protos (even whenswift-protobuf
'sUseAccessLevelOnImports
option is enabled), becauseFoundation
will be imported asinternal
, while we expose public properties of typeData
in the generated code.This PR adds the right
import Foundation
statement based on the import directive.