Add Swift 6 toolchains to CI. #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not update the Package.swift to also support a full Swift 6 mode, that can be done in the future. This just ensure things build in the current setup with the new toolchain as expected. This does not drop 5.8 yet, we'd said policy wise we were going to only support three at a time, not sure if nio has done it yet, maybe do it with them also?
tbkka
approved these changes
Sep 20, 2024
|
Oops, sorry, missed that you'd asked @Lukasa to also review. 😦 |
|
We are beginning to drop 5.8, but we're not in a hurry. We usually do a "one last release" on 5.8 and then drop it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not update the Package.swift to also support a full Swift 6 mode, that can be done in the future. This just ensure things build in the current setup with the new toolchain as expected.
This does not drop 5.8 yet, we'd said policy wise we were going to only support three at a time, not sure if nio has done it yet, maybe do it with them also?