Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add request logs for iOS:APNs and Android:FCM #639

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keremoge
Copy link
Contributor

@keremoge keremoge commented Oct 29, 2021

APNs and FCM Api request logs added to see which requests are going to APNs And FCM servers

Example:

  • request going gorush:
{
  "notifications": [
    {
      "platform": 1,
      "priority": "high",
      "tokens": [
        "**********4wAABp_BOYhKWWMLfSF9GV52UO_rYvBoKbQuuuI6HWSfLdG7_t-ZhA2_Zg47BpQbzBegmHUxovPTp3rU0xajPAfnz9IkOb**********"
      ],
      "content_available": true,
      "category": "CONFIRM",
      "sound": {
        "critical": 1,
        "name": "default",
        "volume": 1
      },
      "alert": {
        "body": "iOS UAT başarılı bildirim geldi"
      },
      "data": {
        "customerNo": 12345,
        "languageCode": "tr",
        "specificCharText": "denemee"
      }
    }
  ]
}
  • request going APNS: (We need this)
{
  "aps": {
    "alert": {
      "body": "iOS UAT başarılı bildirim geldi"
    },
    "category": "CONFIRM",
    "content-available": 1,
    "sound": {
      "critical": 1,
      "name": "default",
      "volume": 1
    }
  },
  "customerNo": 12345,
  "languageCode": "tr",
  "specificCharText": "denemee"
}

@keremoge keremoge changed the title add request logs for iOS:APNS and Android:FCM add request logs for iOS:APNs and Android:FCM Oct 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 64.89%. Comparing base (9d47494) to head (78698fa).
Report is 193 commits behind head on master.

Files Patch % Lines
notify/notification_hms.go 0.00% 7 Missing ⚠️
notify/notification_apns.go 40.00% 1 Missing and 2 partials ⚠️
notify/notification_fcm.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   65.05%   64.89%   -0.16%     
==========================================
  Files          21       21              
  Lines        1783     1792       +9     
==========================================
+ Hits         1160     1163       +3     
- Misses        562      564       +2     
- Partials       61       65       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

storage/redis/redis.go Show resolved Hide resolved
notify/notification_apns.go Outdated Show resolved Hide resolved
notify/notification_apns_test.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@keremoge keremoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@appleboy appleboy force-pushed the master branch 2 times, most recently from 60a7a68 to 2c29b4b Compare June 30, 2022 15:02
@keremoge
Copy link
Contributor Author

keremoge commented Nov 1, 2022

@appleboy can you approve this? It is helpful for debugging

@appleboy appleboy force-pushed the master branch 4 times, most recently from bff0f2d to 6b6ef69 Compare December 24, 2022 13:02
@Spinaker70
Copy link

Indeed, the ability to see the contents of the request in the output is really missing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants