Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for service types #328

Closed
wants to merge 4 commits into from
Closed

Add tests for service types #328

wants to merge 4 commits into from

Conversation

yongja79
Copy link
Collaborator

Signed-off-by: Jason Yong jason_yong@uk.ibm.com

What this PR does / why we need it?:

  • Added service tests for the ClusterIp, LoadBalancer and NodePort types as well as other fields not currently tested

@yongja79
Copy link
Collaborator Author

RCO part of #308

@yongja79 yongja79 requested a review from leochr January 24, 2022 15:27
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongja79 Thanks for the PR. Looks good. It'll be good to add tests to ensure that when fields are unset in CR, the k8s resources are updated accordingly.

Signed-off-by: Jason Yong <jason_yong@uk.ibm.com>
Signed-off-by: Jason Yong <jason_yong@uk.ibm.com>
Signed-off-by: Jason Yong <jason_yong@uk.ibm.com>
Signed-off-by: Jason Yong <jason_yong@uk.ibm.com>
@yongja79
Copy link
Collaborator Author

Made obsolete due to move to common repo

@yongja79 yongja79 closed this Oct 10, 2023
@yongja79 yongja79 deleted the service-tests branch October 10, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants