Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ImplementationSpecific as default for Ingress path type #363

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

halim-lee
Copy link
Collaborator

What this PR does / why we need it?:

  • Ingress resource requires pathType field to be specified. If not set, error will occur. Set ImplementationSpecific as the default value.

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

#341

@halim-lee halim-lee requested a review from leochr April 5, 2022 15:15
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halim-lee Thanks. Looks good. Just one comment about the doc update. Once that's addressed, please merge.

doc/user-guide-v1beta2.adoc Outdated Show resolved Hide resolved
@halim-lee halim-lee merged commit 00ecc1f into main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants