Share controller code for common features #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #342 |
halim-lee
force-pushed
the
consolidate-code
branch
from
061430a
to
3e561f6
Compare
|
@halim-lee please rebase when you get a chance. Thanks |
halim-lee
force-pushed
the
consolidate-code
branch
2 times, most recently
from
02660b6
to
e8df265
Compare
|
@halim-lee Thanks for the updates. Merged multi-arch support PR and that created a conflict with this. Please rebase. |
halim-lee
force-pushed
the
consolidate-code
branch
2 times, most recently
from
578e25b
to
8e65091
Compare
|
All tests passed in ci-pipeline 380 |
|
@halim-lee please rebase and pickup changes from this PR that was just merged: #530 Please check the history of the controller to ensure that some recent changes have been incorporated into the utils. Thank you! |
halim-lee
force-pushed
the
consolidate-code
branch
from
8e65091
to
44105fd
Compare
halim-lee
force-pushed
the
consolidate-code
branch
from
3101015
to
f2824b9
Compare
halim-lee
force-pushed
the
consolidate-code
branch
from
f2824b9
to
8eee438
Compare
halim-lee
changed the title
|
@yongja79 Could you please review? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?:
Does this PR introduce a user-facing change?
CHANGELOG.mdWhich issue(s) this PR fixes: