Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limitiations doc for manageTLS #562

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add limitiations doc for manageTLS #562

wants to merge 6 commits into from

Conversation

idlewis
Copy link
Collaborator

@idlewis idlewis commented Jul 20, 2023

Document that runtime components are responsible for making use of the TLS certificates created by the operator when mangeTLS=true

deals with issue #538

@idlewis idlewis self-assigned this Jul 20, 2023
Document that runtime components are responsible for making use
of the TLS certificates created by the operator when
mangeTLS=true
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idlewis Thanks for the PR. Added a comment about the default value of manageTLS.

It'll be good to further capture the use case with WebSphere Traditional applications (comment from Tam here)


== Limitations
=== Using certificates when manageTLS=true
If `manageTLS=true` is specified in the CR YAML file, then the operator will manage the creation of a TLS secret for the runtime component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manageTLS is true by default - even if it's not specified in CR YAML. It'll be good to mention/clarify so that users don't remove it and expect manageTLS to be false

@idlewis
Copy link
Collaborator Author

idlewis commented Sep 18, 2023

@idlewis Thanks for the PR. Added a comment about the default value of manageTLS.

It'll be good to further capture the use case with WebSphere Traditional applications (comment from Tam here)

@leochr I'm not quite sure how to use the comment from Tam. There seem to be two suggestions on how to work around this issue with tWAS, but I'm guessing that the correct solution would depend on the tWAS configuration.

Were you thinking of documenting a specific use case, such as:
"If your application has its own certificates and will terminate TLS traffic, then set 'manageTLS=false', and 'termination=passthrough' ?

@leochr
Copy link
Member

leochr commented Sep 18, 2023

@idlewis Specific use cases would be more helpful. The troubleshooting doc would be more appropriate than the Limitations section I guess to hold such information. Thanks

@leochr
Copy link
Member

leochr commented Mar 8, 2024

tagging myself as a reminder to review @leochr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants