Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kustomize v5 #646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update to Kustomize v5 #646

wants to merge 1 commit into from

Conversation

halim-lee
Copy link
Collaborator

What this PR does / why we need it?:

  • Updating to Kustomize v5
  • A lot of deprecation from v4 to v5

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #

@leochr
Copy link
Member

leochr commented Aug 27, 2024

@halim-lee Is this something ready to be included in 1.4.0? If so, please resolve the merge conflict (from recent PR merges I guess)

@halim-lee
Copy link
Collaborator Author

@leochr This can go into the next release! It would need more testing on OLO and WLO side

@@ -214,14 +214,6 @@ rules:
- list
- update
- watch
- apiGroups:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally being removed? If so, wondering the reason for it.

@leochr
Copy link
Member

leochr commented Aug 27, 2024

@halim-lee Okay. That'll be fine. I was just wondering whether this would be good to roll out in a minor release (with channel change). But I guess this would be an internal change and wouldn't impact the produced kustomize/kubectl artifacts that users consume, right?

Just added one inquiry about the removal of namespaces from RBAC. I know you are occupied with other things including 1.4.0 items, so I don't expect an answer for it this week. It's not urgent and can wait. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants