Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible Sidebar #317

Merged
merged 25 commits into from
Oct 28, 2019

Conversation

Bazif-Khan
Copy link
Collaborator

Checklist

  • commit message follows commit guidelines.
  • website builds and runs in production - for information on how to test locally go here.

fixes: #299

@Bazif-Khan Bazif-Khan changed the title Feature bk collapsible sidebar Collapsible Sidebar Oct 22, 2019
Copy link
Contributor

@KyeMaloy97 KyeMaloy97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues that jump out to me, but nothing huge:

On iPhone 8 and 8 Plus size classes, the hover state causes the elements to rearrange. This doesn't look great and does affect the usability as when you try to click a link, it jumps around. While theres no hover states on mobile, a narrow window on desktop will show mobile views.

Also, the font increasing in size is causing the sidebar elements to jump around too as the size increase causes the items to increase in height. This could be fixed with a fixed height or something similar, or removing the size change and just showing the chevron and the colour change.

KyeMaloy97
KyeMaloy97 previously approved these changes Oct 28, 2019
Copy link
Contributor

@KyeMaloy97 KyeMaloy97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good now!

Copy link
Contributor

@DunnCoding DunnCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KyeMaloy97 KyeMaloy97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@KyeMaloy97 KyeMaloy97 merged commit 4a14e6c into appsody:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add collapsible capability to docs sidebar
3 participants