Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure installation docs #503

Merged
merged 11 commits into from
Feb 26, 2020

Conversation

helenmasters
Copy link
Contributor

Checklist

  • commit message follows commit guidelines.
  • website builds and runs in production - for information on how to test locally go here.

Description

Complete restructure of the installation related documentation:

  • Split installation docs into one page per OS
  • Create installation overview page
  • Make Getting Started a top level menu
  • Add new pages to sidebar
  • Edit AAD Windows instructions
  • Move SELinux section to FAQ
  • Add redirects for previous install page and getting started page

Related Issues

Fixes #375 #401

- Split installation docs into one page per OS
- Create installation overview page
- Make Getting Started a top level menu
- Add new pages to sidebar
- Edit AAD Windows instructions
- Move SELinux section to FAQ

Fixes appsody#375
@helenmasters
Copy link
Contributor Author

@SueChaplain and @neeraj-laad - following an informal review with Sue & Esther this morning I've pushed up another set of changes to the Overview page.

The only thing stopping this PR being merged (if the rewording can be agreed of course!!!) is that the Testing doc link in the Overview points to a nonexistent doc at the current time.

It would be good to get this merged this week if possible, the Testing link can always be edited out and added in under a separate PR.

@neeraj-laad neeraj-laad added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Feb 20, 2020
- Red Hat Enterprise Linux (RHEL)
- Windows® - Windows 10 Professional and Windows 10 Enterprise editions only

To find out more details about the operating system versions that Appsody tests against, refer to [Testing]().
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you decide where to put the testing information yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I've only got as far as raising an issue appsody/appsody#906. To get this PR merged as is (as this level of detail wasn't in the previous docs either) I'm going to remove this sentence and add it back in when Luke and/or I get the testing doc written.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in next commit.


# Installing Appsody

The easiest way to install Appsody is to use the installers which are available for all supported platforms, except Windows®.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... installers, which ....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next commit.


# Installing on Windows

> Appsody runs only on Windows 10 Professional and Windows 10 Enterprise editions. If you are running Windows 10 Enterprise with authentication through Azure Active Directory, follow the additional instructions in [Appsody and Docker Desktop on Windows 10](/docs/docker-windows-aad).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure about the AAD stuff being in a hidden file. I can remember us discussing a troubleshooting topic at one point, which might be a good place to put this. Maybe we already talked about that?

Copy link
Contributor Author

@helenmasters helenmasters Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've touched on this but not settled on a definitive solution as such. I'd like to get this merged as is and then address moving the AAD stuff (as I don't want to restructure FAQ/Troubleshooting under this PR as that feels like a separate topic).

SueChaplain
SueChaplain previously approved these changes Feb 24, 2020
Copy link
Contributor

@SueChaplain SueChaplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better structure, so thumbs up from me there. Only thing to resolve before merging is where to point people for test information.

Move docker permissions into Prerequisites as per Neeraj's review.
Address Neeraj's review comments by moving docker permissions into pre-reqs.
Remove step 1 when there is only one step.
Updating requirements as per Neeraj's review comments.
@SueChaplain
Copy link
Contributor

@helenmasters - I understand why the pre-req section is changed .... am ok with it. @neeraj-laad are you going to approve so we can merge?

Copy link
Contributor

@neeraj-laad neeraj-laad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neeraj-laad neeraj-laad merged commit f63aa9c into appsody:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure Appsody install documentation
3 participants