Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: restructure build doc #566

Merged
merged 8 commits into from
Apr 20, 2020
Merged

docs: restructure build doc #566

merged 8 commits into from
Apr 20, 2020

Conversation

skoh7645
Copy link
Collaborator

@skoh7645 skoh7645 commented Apr 8, 2020

Checklist

  • commit message follows commit guidelines.
  • website builds and runs in production - for information on how to test locally go here.

Description

Move common flags from "deploying" doc to "building" doc and restructure "building" doc

Related Issues

Related to #359

@skoh7645 skoh7645 mentioned this pull request Apr 8, 2020
2 tasks
content/docs/using-appsody/building.md Outdated Show resolved Hide resolved
content/docs/using-appsody/deploying.md Outdated Show resolved Hide resolved
@skoh7645 skoh7645 self-assigned this Apr 16, 2020
The application image built by `appsody build` will be tagged with the name `mynamespace/myrepository[:tag]`, and pushed to the registry at the URL that you specify with `<registry-url:PORT>`.

> If `--push-url` flag is not specified, the image is pushed to DockerHub. A push is triggered when using the `--push-url` flag even if the `--push` flag is not specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be 2 separate notes?

Copy link
Contributor

@neeraj-laad neeraj-laad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neeraj-laad neeraj-laad merged commit ce08f72 into appsody:master Apr 20, 2020
@skoh7645 skoh7645 deleted the builddoc branch April 20, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants