Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to echo database version and file path #67

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

Toreno96
Copy link
Collaborator

@Toreno96 Toreno96 commented Dec 15, 2023

Fixes #32.


The final interface is slightly different than what was suggested in the related issue. I can't recall my exact reasoning (I implemented that a long time ago; it was waiting for me to finally push it to the repo since then), but it seems to be subjectively more concise and simple than the alternatives. It also works better with the fact that printing the version requires a master key, and printing the file path alone does not—the latter is the default action because of that fact. It also works on the assumption that if someone really needs only the version, they can always pipe the output into something like | cut -d'(' -f2 | sed 's/)//'.

I think I wasn't a fan of db version because it's inconsistent with otp --version, which I plan to introduce at some point. I'm not a fan of otp version, as --version seems to be preferred in the classic CLIs, and I personally always default to using --version or -v when trying to fetch a version of any tool. That's opinionated, obviously, but the whole point of onetimepass is to be the most comfortable 2FA client for me, primarily, and then for any other potential users.


I guess this is also the PR that begins an experiment to gravitate away from naming PRs and commits with nothing more than Fix #xy. We'll see how it works.

@Toreno96 Toreno96 merged commit 2ff3bdc into master Dec 15, 2023
2 checks passed
@Toreno96 Toreno96 deleted the issue-32 branch December 15, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command for echoing the db version and file path
1 participant