Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression after renaming *algorithm variables #76

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix regression after renaming *algorithm variables #76

merged 1 commit into from
Dec 22, 2023

Conversation

Toreno96
Copy link
Collaborator

Fixes #75.

@Toreno96
Fix regression after renaming *algorithm variables
c3f79c5 
Fixes #75.

* * *

After 6592be2
(#68) , if URI contains
the `algorithm` optional parameter, e.g.

```
otpauth://totp/ACME%20Co:john.doe@email.com?secret=HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ&issuer=ACME%20Co&algorithm=SHA1&digits=6&period=30
```

the application will raise an error:

```
[2023-12-21 09:42:02,769] DEBUG:otp:352: 1 validation error for Uri
schema_ -> TOTPUriSchema -> parameters -> algorithm
  extra fields not permitted (type=value_error.extra)
```
@Toreno96 Toreno96 merged commit 961df32 into master Dec 22, 2023
2 checks passed
@Toreno96 Toreno96 deleted the issue-75 branch December 22, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression after renaming *algorithm variables
1 participant
@Toreno96