Fix secret not being case-insensitive
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #80. * * * Example secret provided by Google when trying to enable MFA for Google account (with the note that spaces can be ignored): ``` qea4 ptmn kvd5 ampv wm6d rc6m bbh4 urbo ``` Example respective URI: ``` otpauth://totp/Google%3Adaniel%40buttercms.com?secret=qea4ptmnkvd5ampvwm6drc6mbbh4urbo&issuer=Google ``` Result: ``` $ otp add uri google Enter URI: Repeat for confirmation: Usage: otp add uri [OPTIONS] ALIAS Try 'otp add uri -h' for help. Error: invalid Base32 value; Non-base32 digit found ``` This _is_ Base32-encoded, **however**, Google ignores the [official spec](https://datatracker.ietf.org/doc/html/rfc3548#section-5) that instructs to use **uppercase** letters for Base32-encoded value. On the other hand, the spec also mentions case insensitivity of the value: > The Base 32 encoding is designed to represent arbitrary sequences of > octets in a form that needs to be case insensitive So maybe the issue comes from the spec being ambiguous. We should make the `secret` parameter case-insensitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80.