-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook for adding input layers and operators #275
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
=======================================
Coverage ? 71.24%
=======================================
Files ? 45
Lines ? 4782
Branches ? 708
=======================================
Hits ? 3407
Misses ? 1176
Partials ? 199 ☔ View full report in Codecov by Sentry. |
Thanks a lot! I think the how-to-add-an-operator notebook has lower priority and does not need to be merged soon, so I just have some suggestions for the how-add-a-layer notebook:
|
I would say yes, because it's also important to make full use of cirkit. But they indeed face different levels of users.
I agree. There're some duplicates in the two notebooks, and we may do it in three: add-layer, layer-op, and circuit-op.
Thanks for pointing out. This will be better for end-users. |
@lkct what's the status on this? |
I will finalize it. I have to rearrange the sections and catch up with the API changes. |
As per title.
Also some minor changes:
Layer._make_param
to reduce duplicate code.