Fix returncode when deleting a mirror with snapshot #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1201 +/- ##
==========================================
- Coverage 65.99% 65.97% -0.02%
==========================================
Files 143 143
Lines 16196 16190 -6
==========================================
- Hits 10688 10682 -6
- Misses 4754 4756 +2
+ Partials 754 752 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It's HTTP |
reglim
suggested changes
Aug 18, 2023
When trying to delete a mirror that has snapshot and not providing the force option, the API should not return a `500 StatusInternalServerError`. A `403 StatusForbidden` is more appropriate when the condition is expected by the server.
acdn-ndostert
force-pushed
the
fix-api-mirror-drop-returncode
branch
from
1689ee5
to
5e83a20
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to delete a mirror that has snapshot and not providing the force option, the API should not return a
500 StatusInternalServerError.A
403 StatusForbiddenis more appropriate when the condition is expected by the server.Fixes #
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
I was able to run
make modules installandmake testwith success but I'm not able to runmake system-testbecause of missing dependencies (gpg1).Description of the Change
When implementing a client for Aptly API the
500HTTP status code returned does not make it clear that there is an issue with the request.From https://www.rfc-editor.org/rfc/rfc9110.html#name-500-internal-server-error
The condition preventing the request to be fulfill is not unexpected and is even documented in the response.
Checklist
- [ ] unit-test added (if change is algorithm)- [ ] functional test added/updated (if change is functional)- [ ] man page updated (if applicable)- [ ] bash completion updated (if applicable)- [ ] documentation updatedAUTHORS