Fix: Remove Batch from API options, set to true by default #1208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to expose the Batch option, which, if
false
enables input from stdin for gpg passphrases, which blocks the api thread. Because of this, I removed the option, and set it totrue
by default.Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Batch
optionBatch
to true internallyWhy this change is important?
So the API can't get hung up because a user tries to sign a publish with a key that requires a passphrase he didn't provide in the request.
Checklist
AUTHORS