Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add arm builds #1286

Closed
wants to merge 37 commits into from
Closed

github: add arm builds #1286

wants to merge 37 commits into from

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 21, 2024

Fixes #1199, #960, #1108

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

  • replace goxc and use go directly for debian builds
  • debianize and use dpkg-buildpackage for building debian packages
  • read go version from go.mod
  • read package version from debian/changelog
  • build FreeBSD, MacOS and Linux separately

TODO

@neolynx neolynx self-assigned this Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (9591548) to head (88b9513).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
s3/public.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1286      +/-   ##
==========================================
- Coverage   74.51%   74.51%   -0.01%     
==========================================
  Files         150      150              
  Lines       16994    16997       +3     
==========================================
+ Hits        12663    12665       +2     
- Misses       3322     3323       +1     
  Partials     1009     1009              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx
Copy link
Member Author

neolynx commented Apr 21, 2024

goxc does not seem to build for arm64:

ls -l build/
total 168736
-rw-r--r-- 1 root root 17893770 Apr 21 17:19 aptly_1.5.0+113+g6619f929_amd64.deb
-rw-r--r-- 1 root root 16546322 Apr 21 17:19 aptly_1.5.0+113+g6619f929_armhf.deb
-rw-r--r-- 1 root root 18089983 Apr 21 17:19 aptly_1.5.0+113+g6619f929_darwin_amd64.zip
-rw-r--r-- 1 root root 17016974 Apr 21 17:19 aptly_1.5.0+113+g6619f929_freebsd_386.zip
-rw-r--r-- 1 root root 17883988 Apr 21 17:19 aptly_1.5.0+113+g6619f929_freebsd_amd64.zip
-rw-r--r-- 1 root root 17057506 Apr 21 17:19 aptly_1.5.0+113+g6619f929_i386.deb
-rw-r--r-- 1 root root 17049372 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_386.tar.gz
-rw-r--r-- 1 root root 17887161 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_amd64.tar.gz
-rw-r--r-- 1 root root 16539569 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_arm.tar.gz
-rw-r--r-- 1 root root 16802958 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_arm64.tar.gz

-> depends on #1287

@neolynx neolynx changed the title gituhub: add arm builder workflow github: add arm builds Apr 21, 2024
@neolynx neolynx force-pushed the feature/arm-builds branch 2 times, most recently from ce1937c to 73040d1 Compare April 24, 2024 16:01
@neolynx neolynx force-pushed the feature/arm-builds branch from 4d02050 to aa83fba Compare June 1, 2024 22:05
@neolynx neolynx force-pushed the feature/arm-builds branch from 8369306 to 951bd7b Compare June 15, 2024 20:49
@neolynx neolynx force-pushed the feature/arm-builds branch from 951bd7b to 2e8353f Compare July 3, 2024 16:29
@neolynx neolynx force-pushed the feature/arm-builds branch 4 times, most recently from a0359d9 to 49cb0f1 Compare August 1, 2024 20:17
@neolynx neolynx changed the base branch from master to feature/s3tests August 1, 2024 20:21
@neolynx neolynx changed the base branch from feature/s3tests to master August 1, 2024 20:22
@neolynx neolynx force-pushed the feature/arm-builds branch 6 times, most recently from 70b75bf to f3a0289 Compare August 3, 2024 22:25
- fix make version on debian
- update gitignore
- add aptly-api and service
- disable metrics
- disable prometheus
- disable unit tests
- disable system tests
- reenable some system test
- use go 1.19
- Makefile: improve unit test output
- cleanup: remove travis
@neolynx neolynx force-pushed the feature/arm-builds branch from 71d1af6 to 3dc1986 Compare August 11, 2024 11:15
use the new -multi-dist option to combine all distributions into one
publish point:

deb http://repo.aptly.info/ci bookworm main

or:

deb http://repo.aptly.info/release bookworm main

for the following distributions: buster, bullseye, bookworm, focal, jammy
@neolynx
Copy link
Member Author

neolynx commented Sep 14, 2024

replaced by #1339

@neolynx neolynx closed this Sep 14, 2024
@neolynx neolynx deleted the feature/arm-builds branch September 25, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add arm64 deb builds to main repo
1 participant