Remove request url forward slash append (#264)

remove request url forward slash append
aptos-labs · Jan 24, 2024 · 95a54f4 · 95a54f4
1 parent 4bad825
commit 95a54f4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@ All notable changes to the Aptos TypeScript SDK will be captured in this file. T
 
 # Unreleased
 
+- Remove request URLs forward slash append
+
 # 1.4.0 (2024-01-08)
 
 - Omit `"build" | "simulate" | "submit"` from `aptos` namespace

diff --git a/src/client/core.ts b/src/client/core.ts
@@ -68,7 +68,7 @@ export async function aptosRequest<Req extends {}, Res extends {}>(
   aptosConfig: AptosConfig,
 ): Promise<AptosResponse<Req, Res>> {
   const { url, path } = options;
-  const fullUrl = `${url}/${path ?? ""}`;
+  const fullUrl = path ? `${url}/${path}` : url;
   const response = await request<Req, Res>({ ...options, url: fullUrl }, aptosConfig.client);
 
   const result: AptosResponse<Req, Res> = {

diff --git a/tests/e2e/client/aptosRequest.test.ts b/tests/e2e/client/aptosRequest.test.ts
@@ -338,7 +338,7 @@ describe("aptos request", () => {
             );
           } catch (error: any) {
             expect(error).toBeInstanceOf(AptosApiError);
-            expect(error.url).toBe(`${NetworkToIndexerAPI[config.network]}/`);
+            expect(error.url).toBe(`${NetworkToIndexerAPI[config.network]}`);
             expect(error.status).toBe(200);
             expect(error.statusText).toBe("OK");
             expect(error.data).toHaveProperty("errors");