[SDKv2] Update the Faucet class and fix param naming #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
0xmigo
changed the title
0xmigo
requested review from
0xmaayan,
gregnazario,
heliuchuan,
xbtmatt and
a team
xbtmatt
approved these changes
Oct 11, 2023
gregnazario
reviewed
Oct 11, 2023
gregnazario
reviewed
Oct 11, 2023
0xmigo
force-pushed
the
jin/Update_fix_faucet
branch
from
73d82cd to
b02f106
Compare
0xmaayan
reviewed
Oct 11, 2023
0xmaayan
reviewed
Oct 11, 2023
0xmaayan
requested changes
Oct 11, 2023
banool
reviewed
Oct 11, 2023
src/internal/faucet.ts
Outdated
| amount: number; | ||
| timeoutSecs?: number; | ||
| }): Promise<Array<string>> { | ||
| const { aptosConfig, accountAddress, amount } = args; | ||
| const timeoutSecs = args.timeoutSecs ?? DEFAULT_TXN_TIMEOUT_SEC; | ||
| const { data } = await postAptosFaucet<any, Array<string>>({ | ||
| aptosConfig, | ||
| body: null, | ||
| path: "mint", |
There was a problem hiding this comment.
Let's land Greg's stuff first? It switches us to fund.
0xmigo
force-pushed
the
jin/Update_fix_faucet
branch
from
b02f106 to
d19eaf5
Compare
gregnazario
approved these changes
Oct 11, 2023
| const testAccount = Account.generate({ scheme: SigningScheme.Ed25519 }); | ||
|
|
||
| // Fund the account | ||
| await aptos.fundAccount({ accountAddress: testAccount.accountAddress.toString(), amount: 10_000_000 }); |
There was a problem hiding this comment.
Yeah, this I see is why you don't want to pass the string, and instead the account address, we'll have to review this whole input strategy afterwards
There was a problem hiding this comment.
Yep. Including the args as input param on some places, we can revisit after Alpha :)
0xmaayan
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
accountAddresstoaddressTest Plan
pnpm test
Related Links