[types] Remove requirement on 0x for input #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
requested review from
0xmaayan,
0xmigo,
heliuchuan and
a team
as code owners
0xmigo
approved these changes
Oct 24, 2023
Comment on lines
+642
to
+644
| export type MoveAddressType = string; | ||
| export type MoveObjectType = string; | ||
| export type MoveStructType = `${string}::${string}::${string}`; |
There was a problem hiding this comment.
I suspect user (like me) will dig in and check what these types are.
Shall we add a note here for the user to know, that there should be 0x prefix?
There was a problem hiding this comment.
We can probably document that on each type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes needing to do silliness like:
0x${HexInput.toStringWithoutPrefix()}...Test Plan
Related Links