Use test constants keys/function address #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
reviewed
Oct 11, 2023
| @@ -26,7 +27,7 @@ describe("transaction submission", () => { | |||
| const aptos = new Aptos(config); | |||
| const alice = Account.fromPrivateKey({ | |||
| privateKey: new Ed25519PrivateKey({ | |||
| hexInput: "0x5aba8dab1c523be32bd4dafe2cc612f7f8050ce42a3322b60216ef67dc97768c", | |||
| hexInput: ALICE_PRIVATE_KEY, | |||
There was a problem hiding this comment.
these tests are going to change. We now test it against devnet and eventually will change it to run against localnet. We had these fix accounts because we couldn't use the fund query so we fund it using the cli and "created" it on devnet.
We will probably not use any fix private keys to create an account but create and fund it on run time
0xmaayan
requested changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns the commonly used test private keys and entry function addresses into consts
Test Plan
pnpm test