[Tests] Added script functions to argument types test suite #157
Conversation
xbtmatt
requested review from
0xmaayan,
gregnazario,
0xmigo,
heliuchuan and
a team
as code owners
xbtmatt
force-pushed
the
matt/args-test
branch
2 times, most recently
from
78b29d4 to
cbe6643
Compare
tests/e2e/transaction/helper.ts
Outdated
| const transaction = await aptos.generateTransaction({ | ||
| sender: firstAccount.accountAddress.toString(), | ||
| data: { | ||
| function: `0x${1}::aptos_account::batch_transfer`, |
There was a problem hiding this comment.
Lol why like this? If this is doing a pattern match that makes you do something like this, we need to fix it and remove the pattern match
There was a problem hiding this comment.
Lol I have no idea why I did this- it's fine with just the string, I updated it
| function: `0x${1}::aptos_account::batch_transfer`, | ||
| functionArguments: [ | ||
| new MoveVector(addressesRemaining), | ||
| MoveVector.U64(addressesRemaining.map(() => amountToSend)), |
There was a problem hiding this comment.
Why map if it's exactly one?
| await aptos.fundAccount({ accountAddress: firstAccount.accountAddress.toString(), amount: FUND_AMOUNT }); | ||
| // Fund again because these txns can be expensive | ||
| await aptos.fundAccount({ accountAddress: firstAccount.accountAddress.toString(), amount: FUND_AMOUNT }); | ||
| const addressesRemaining = accounts.slice(1).map((account) => account.accountAddress); |
There was a problem hiding this comment.
Why not just accounts[1]
There was a problem hiding this comment.
I'll put a comment explaining it so it's easier to read, but it's sending the coins from account[0] out to accounts[1..n] not just accounts[1]
There was a problem hiding this comment.
if end in Array.slice(start?: number, end?: number) is undefined then it returns the slice from start to the end
…pt args instead of various signers
xbtmatt
force-pushed
the
matt/args-test
branch
from
cbe6643 to
a8f05be
Compare
Description
Updated the test suite to use scripts
The sender/authenticator type is already validated in transaction submission, so in order to keep this test focused, I just added scripts instead of adding all the different signer types.
Test suite
TODO:
Argument types
Number of signers
TODO:
NOTE: Also added a small fix to the script function vector
U8serialize function. This is only needed forU8because script functions don't accept any other vector type.Test Plan