Create input submit transaction interface type #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
requested review from
gregnazario,
0xmigo,
heliuchuan and
a team
as code owners
gregnazario
approved these changes
Nov 2, 2023
src/transactions/types.ts
Outdated
Comment on lines
312
to
315
| secondarySignerAuthenticators?: { | ||
| feePayerAuthenticator?: AccountAuthenticator; | ||
| additionalSignersAuthenticators?: Array<AccountAuthenticator>; | ||
| }; |
There was a problem hiding this comment.
This is a little weird now that i'm looking at it that, secondary signers, contains fee payer and additional signers.
We may want to flatten this to two top level optionals. (Or rename the outside additional, and the internal one secondary which matches the API)
There was a problem hiding this comment.
agreed. ill flatten it
0xmaayan
force-pushed
the
input_submit_data
branch
from
3aff6cc to
088816b
Compare
gregnazario
approved these changes
Nov 2, 2023
0xmaayan
force-pushed
the
input_submit_data
branch
from
088816b to
ad0f528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
secondarySignerAuthenticatorslayerTest Plan
Related Links