Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.6.0 #284

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Bump version to 1.6.0 #284

merged 1 commit into from
Feb 8, 2024

Conversation

0xmaayan
Copy link
Collaborator

@0xmaayan 0xmaayan commented Feb 8, 2024

Description

Test Plan

Related Links

@0xmaayan 0xmaayan requested a review from a team as a code owner February 8, 2024 18:44
Copy link

@BriungRi BriungRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't look much at added files, modifications seem reasonable.

side thought is, would it be possible to only include these *.html files locally as opposed to checking them in? Asking because these look like generated files

@0xmaayan
Copy link
Collaborator Author

0xmaayan commented Feb 8, 2024

didn't look much at added files, modifications seem reasonable.

side thought is, would it be possible to only include these *.html files locally as opposed to checking them in? Asking because these look like generated files

good question. I am not completely sure how it works if it is possible since eventually those files should be live here https://aptos-labs.github.io/aptos-ts-sdk/

@0xmaayan 0xmaayan merged commit 91b1bf4 into main Feb 8, 2024
7 checks passed
@0xmaayan 0xmaayan deleted the bump_sdk_version branch February 8, 2024 19:22
@gregnazario
Copy link
Collaborator

didn't look much at added files, modifications seem reasonable.

side thought is, would it be possible to only include these *.html files locally as opposed to checking them in? Asking because these look like generated files

Github pages is hosting these statically. For now, it's easiest to do it this way.

We can probably also just run the doc generation on the fly, but that might require more work / not keep the old versions static to older docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants