Use node API via API Gateway #302
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banool
force-pushed
the
banool/node-api-gateway
branch
from
d42132a to
3b01d73
Compare
banool
force-pushed
the
banool/node-api-gateway
branch
from
3b01d73 to
c493c2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of the migration to API Gateway. More context here: https://www.notion.so/aptoslabs/Migration-1-Legacy-URL-to-API-Gateway-migration-b007742490684b9bab3debd674504a94.
I found the initial files to change like this:
I then did a find replace from
fullnode.([a-z]{3,6}net).aptoslabs.comtoapi.$1.aptoslabs.com.I did some further digging, e.g. for places where we perhaps build the URL, by just looking at every file that references
aptoslabs.com. Hopefully this is everything.I haven't touched indexer API, we'll do that in another PR.
Test Plan
CI for now.