Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate IIFE build support #317

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Deprecate IIFE build support #317

merged 1 commit into from
Feb 29, 2024

Conversation

0xmaayan
Copy link
Collaborator

Description

Following discussions, we decided to remove IIFE build support

  1. It increases the overall package size in more than 2MB
  2. Creates issues when integrating packages without IIFE support
  3. If we do want to support those packages we need to inject polyfills which highly increased maintenance work and package size
  4. We dont feel there is a valid reason for devs to use IIFE format these days

https://aptos-org.slack.com/archives/C03N83P7QUC/p1709228938688099

https://aptos-org.slack.com/archives/C066E8D05P0/p1709162304228609

Test Plan

Related Links

@0xmaayan 0xmaayan requested a review from a team as a code owner February 29, 2024 18:29
@0xmaayan 0xmaayan merged commit a23ccc6 into main Feb 29, 2024
7 checks passed
@0xmaayan 0xmaayan deleted the remove_iife branch February 29, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariria hariria hariria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmaayan @hariria