Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Unify all test imports and fix lint issues #32

Closed
wants to merge 2 commits into from

Conversation

gregnazario
Copy link
Collaborator

Description

These lint issues pointed out several problems with some of the tests, so hopefully this being on will help keep good practices in tests.

Test Plan

pnpm lint && pnpm test, it requires the changes from the other fix as well.

Related Links

Dependent on #31

gregnazario and others added 2 commits October 12, 2023 08:07
These lint issues pointed out several problems with some of
the tests, so hopefully this being on will help keep good
practices in tests.
Co-authored-by: Matt <90358481+xbtmatt@users.noreply.github.com>
@gregnazario
Copy link
Collaborator Author

Closing for now in favor of a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants