[types] Ensure string is checked before other types

CHANGELOG.md

@@ -4,6 +4,8 @@ All notable changes to the Aptos TypeScript SDK will be captured in this file. T
 
 # Unreleased
 
+- [`Fix`] Ensure that hex input strings are loaded as strings in Javascript
+
 # 1.10.0 (2024-03-11)
 
 - [`Deprecate`] IIFE build support

examples/javascript/simple_transfer.js

@@ -56,7 +56,7 @@ const example = async () => {
   console.log("\n=== Funding accounts ===\n");
 
   const aliceFundTxn = await sdk.fundAccount({
-    accountAddress: alice.accountAddress,
+    accountAddress: alice.accountAddress.toString(),
     amount: ALICE_INITIAL_BALANCE,
   });
   console.log("Alice's fund transaction: ", aliceFundTxn);

src/core/accountAddress.ts

@@ -342,13 +342,13 @@ export class AccountAddress extends Serializable implements TransactionArgument
    * @param input
    */
   static from(input: AccountAddressInput): AccountAddress {
+    if (typeof input === "string") {
+      return AccountAddress.fromString(input);
+    }
     if (input instanceof AccountAddress) {
       return input;
     }
-    if (input instanceof Uint8Array) {
-      return new AccountAddress(input);
-    }
-    return AccountAddress.fromString(input);
+    return new AccountAddress(input);
   }
 
   /**
@@ -358,13 +358,13 @@ export class AccountAddress extends Serializable implements TransactionArgument
    * @param input
    */
   static fromStrict(input: AccountAddressInput): AccountAddress {
-    if (input instanceof AccountAddress) {
-      return input;
+    if (typeof input === "string") {
+      return AccountAddress.fromStringStrict(input);
     }
     if (input instanceof Uint8Array) {
       return new AccountAddress(input);
     }
-    return AccountAddress.fromStringStrict(input);
+    return input;
   }
 
   // ===

src/core/hex.ts

@@ -131,8 +131,11 @@ export class Hex {
    * @returns Hex
    */
   static fromHexInput(hexInput: HexInput): Hex {
-    if (hexInput instanceof Uint8Array) return new Hex(hexInput);
-    return Hex.fromString(hexInput);
+    // Note we have to be more defensive here, since Javascript doesn't have the concept of types
+    if (typeof hexInput === "string") {
+      return Hex.fromString(hexInput);
+    }
+    return new Hex(hexInput);
   }
 
   // ===