Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[view] Abi upgrades #334

Merged
merged 8 commits into from
Mar 26, 2024
Merged

[view] Abi upgrades #334

merged 8 commits into from
Mar 26, 2024

Conversation

gregnazario
Copy link
Collaborator

Description

  • Adds optional signers to Entry function ABI. This allows for later checking number of signatures on an entry function
  • Move view functions to BCS over JSON based. Allows for proper type checking and more expressive inputs.
  • Disable code splitting on CJS. There seems to be some strange bug associated with the view function code that causes it to fail to link up code correctly. Turning off code splitting fixes it, but this might not be the right solution.

Test Plan

See examples and existing tests

Related Links

@gregnazario gregnazario requested a review from a team as a code owner March 21, 2024 22:18
0xmaayan
0xmaayan reviewed Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just need to figure out the splitting issue

src/transactions/types.ts Show resolved Hide resolved
tests/e2e/api/general.test.ts Outdated Show resolved Hide resolved
tsup.config.ts Outdated Show resolved Hide resolved
src/transactions/types.ts Outdated Show resolved Hide resolved
src/transactions/transactionBuilder/remoteAbi.ts Show resolved Hide resolved
src/transactions/transactionBuilder/remoteAbi.ts Show resolved Hide resolved
src/transactions/transactionBuilder/remoteAbi.ts Outdated Show resolved Hide resolved
src/transactions/transactionBuilder/transactionBuilder.ts Outdated Show resolved Hide resolved
src/transactions/transactionBuilder/transactionBuilder.ts Outdated Show resolved Hide resolved
src/transactions/types.ts Outdated Show resolved Hide resolved
@gregnazario gregnazario enabled auto-merge (rebase) March 23, 2024 03:23
@gregnazario gregnazario disabled auto-merge March 26, 2024 16:48
@gregnazario gregnazario enabled auto-merge (squash) March 26, 2024 16:49
@gregnazario gregnazario requested a review from 0xmaayan March 26, 2024 16:50
0xmaayan
0xmaayan reviewed Mar 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/transactions/types.ts Outdated Show resolved Hide resolved
tests/e2e/api/general.test.ts Outdated Show resolved Hide resolved
src/transactions/types.ts Show resolved Hide resolved
@gregnazario gregnazario disabled auto-merge March 26, 2024 16:58
@gregnazario gregnazario merged commit 19506cf into main Mar 26, 2024
8 checks passed
@gregnazario gregnazario deleted the abi-upgrades branch March 26, 2024 18:59
@SamuelQZQ SamuelQZQ mentioned this pull request Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmaayan 0xmaayan 0xmaayan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregnazario @0xmaayan