Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculate object address and token address #339

Merged
merged 1 commit into from
Mar 25, 2024
Merged

calculate object address and token address #339

merged 1 commit into from
Mar 25, 2024

Conversation

0xmaayan
Copy link
Collaborator

Description

Following https://aptos-org.slack.com/archives/C05NLAKJM9U/p1711053989343899 , adding local object address calculation

Test Plan

Related Links

@0xmaayan 0xmaayan requested a review from BriungRi March 25, 2024 15:38
JohnChangUK
JohnChangUK approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@JohnChangUK JohnChangUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, verified!

BriungRi
BriungRi reviewed Mar 25, 2024
View reviewed changes
src/core/account/utils/address.ts Outdated Show resolved Hide resolved
src/core/account/utils/address.ts Outdated Show resolved Hide resolved
src/core/account/utils/address.ts Outdated Show resolved Hide resolved
src/core/account/utils/address.ts Outdated Show resolved Hide resolved
@0xmaayan 0xmaayan force-pushed the calculate_object_address branch 2 times, most recently from a5e354b to cea70ad Compare March 25, 2024 17:48
@0xmaayan 0xmaayan marked this pull request as ready for review March 25, 2024 17:48
@0xmaayan 0xmaayan requested a review from a team as a code owner March 25, 2024 17:48
BriungRi
BriungRi approved these changes Mar 25, 2024
View reviewed changes
Copy link

@BriungRi BriungRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments, some are just nit (sorry!)

LGTM!

@0xmaayan 0xmaayan force-pushed the calculate_object_address branch from cea70ad to 51253ce Compare March 25, 2024 19:01
@0xmaayan 0xmaayan requested a review from a team March 25, 2024 19:01
@0xmaayan 0xmaayan force-pushed the calculate_object_address branch from 51253ce to 81640c4 Compare March 25, 2024 19:17
@0xmaayan 0xmaayan merged commit 0743e80 into main Mar 25, 2024
8 checks passed
@0xmaayan 0xmaayan deleted the calculate_object_address branch March 25, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnChangUK JohnChangUK JohnChangUK approved these changes

@BriungRi BriungRi BriungRi approved these changes

@gregnazario gregnazario gregnazario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xmaayan @gregnazario @BriungRi @JohnChangUK