[Tests] Transaction submission test suite. The initial attempt at testing all authenticators, payloads and argument types #34

xbtmatt · 2023-10-12T09:02:31Z

Test suite

TODO:

Add 1 - n signers for the functions
Verify the order of signers in the contract with assertions

Argument types

basic argument types
vector argument types
option argument types

Authenticators & payloads

Ed25519 (1 sender, 1 signer)

public entry function
private entry function
script

Secp256k1 (1 sender, 1 signer)

public entry function
private entry function
script

MultiEd25519 (k-of-n signers)

TODO

Multi Agent (1 sender, n - 1 secondary signers, n signers)

Fee Payer (1 sender, 1 fee payer, 0 - n signers)

Miscellaneous:

view function of all the argument types listed above
type tags, including various nested generics

gregnazario · 2023-10-12T20:03:11Z

src/bcs/serializable/move-structs.ts

@@ -439,7 +439,7 @@ export class MoveObject extends Serializable implements TransactionArgument {
    if (value instanceof AccountAddress) {
      this.value = value;
    } else {
-      this.value = AccountAddress.fromHexInput({ input: value });
+      this.value = AccountAddress.fromHexInputRelaxed({ input: value });


Why is this changing?

I would like to use relaxed if we can, I was running into a bunch of errors because of it- basically what we were talking about with daniel

I was just putting it here as a fix so I didn't have to fix every instance of an object in the test suite (I wrote it down as feedback/things to think about in the doc), but yea, the issue was I was getting errors from addresses I was getting from the API on chain

xbtmatt · 2023-10-13T18:37:26Z

TODO: I think we could add something like these (just with single signer, ed25519) as a bcs-examples.ts file to show people how to use the new stuff, since it is very comprehensive

…c/private entry functions with all argument types working e2e. Also, changing Object to use fromHexInputRelaxed. Also added FixedBytes to the different argument types.

… multi agent tx submission in unit tests

gregnazario

This is a lot of code. Let's please break this up into functions in the future for each step rather than have a really really big beforeAll

gregnazario · 2023-10-14T00:48:43Z

tests/e2e/api/transaction_arguments.test.ts

+  UserTransactionResponse,
+} from "../../../src/types";
+
+jest.setTimeout(30000);


Is there a test that's actually taking 30 seconds?

No, I think I just changed it to 30 to make sure it wouldn't fail, I think I can do like 10 or 15

gregnazario · 2023-10-14T00:52:38Z

tests/e2e/api/transaction_arguments.test.ts

+    account1 = Account.generate();
+    account2 = Account.generate();
+    account3 = Account.generate();
+    account4 = Account.generate();
+    account5 = Account.generate();


Probably would have been easier just to have an array of accounts.

gregnazario · 2023-10-14T00:52:54Z

tests/e2e/api/transaction_arguments.test.ts

+    for (const account of accounts) {
+      await aptos.fundAccount({
+        accountAddress: account.accountAddress.data,
+        amount: 100_000_000,


We have a constant for this now

gregnazario · 2023-10-14T00:53:29Z

tests/e2e/api/transaction_arguments.test.ts

+        if (secondarySignerAddresses.length == 0) {
+          const response = await aptos.generateTransaction({
+            sender: sender.accountAddress.toString(),
+            data: {
+              function: `0x${account1.accountAddress.toStringWithoutPrefix()}::tx_args_module::${functionName}`,
+              type_arguments: typeArgs,
+              arguments: args,
+            },
+            feePayerAddress: feePayerAddress!.data,
+          });
+          return response;
+        } else if (feePayerAddress === undefined) {
+          return await aptos.generateTransaction({
+            sender: sender.accountAddress.toString(),
+            data: {
+              function: `0x${account1.accountAddress.toStringWithoutPrefix()}::tx_args_module::${functionName}`,
+              type_arguments: typeArgs,
+              arguments: args,
+            },
+            secondarySignerAddresses: secondarySignerAddresses.map((address) => address.data),
+          });
+        } else {
+          return await aptos.generateTransaction({


:/ super fragile, but we'll have to come back

Yeah, the only reason I did it like this is because the types weren't resolving correctly, otherwise it should have correctly resolved to a general type with no if/else blocks

gregnazario · 2023-10-14T00:53:44Z

tests/e2e/api/transaction_arguments.test.ts

+          return await aptos.generateTransaction({
+            sender: sender.accountAddress.toString(),
+            data: {
+              function: `0x${account1.accountAddress.toStringWithoutPrefix()}::tx_args_module::${functionName}`,


Why not just do toString() with the prefix instead of adding the 0x?

was wondering why I would ever do this and remembered the issue is the type is that 0x${...}::${...} type, so it gets mad otherwise

gregnazario · 2023-10-14T00:53:56Z

tests/e2e/api/transaction_arguments.test.ts

+
+      const accounts = [sender, account2, account3, account4, account5];
+      // sign wtih an account its address is in secondarySignerAddresses OR if it's the sender
+      // TODO: Fix the ugly


tests/e2e/api/transaction_arguments.test.ts

0xmaayan

it is a big test. maybe we should put all transactions tests under a transactions folder. can also have a helper file for transaction specific tests

0xmaayan · 2023-10-12T17:09:50Z

src/bcs/serializable/move-structs.ts

@@ -439,7 +439,7 @@ export class MoveObject extends Serializable implements TransactionArgument {
    if (value instanceof AccountAddress) {
      this.value = value;
    } else {
-      this.value = AccountAddress.fromHexInput({ input: value });
+      this.value = AccountAddress.fromHexInputRelaxed({ input: value });


interesting... curios why?

Because I was getting objects from the API, it returned it with no leading 0, meaning I needed to sanitize my input. I then realized I don't see in any case why someone wouldn't want the "relaxed" version when using it as input.

You generally would only use a MoveObject to serialize an entry function argument, so the end serialization result is the same regardless of whether or not you input a 0x0... or 0x..., so fromHexInputRelaxed makes more sense to me than having people run into errors 1/16 times because they didn't expect the address they passed in to to fail the parsing test

0xmaayan · 2023-10-14T01:09:25Z

tests/e2e/api/transaction_arguments.test.ts

+      transaction: rawTxn,
+      senderAuthenticator: signedTxn,
+    });
+    const _ = await aptos.waitForTransaction({


does it complain if you dont do const _ = ?

no I'm not sure why I did that tbh, removed it

gregnazario reviewed Oct 12, 2023

View reviewed changes

xbtmatt force-pushed the transaction-arguments branch from 5b9f02f to 5875397 Compare October 13, 2023 07:08

xbtmatt changed the title ~~[Tests] Transaction submission test suite. All combinations of authenticators, payloads and argument types~~ [Tests] Transaction submission test suite. The initial attempt at tseting all authenticators, payloads and argument types Oct 13, 2023

xbtmatt changed the title ~~[Tests] Transaction submission test suite. The initial attempt at tseting all authenticators, payloads and argument types~~ [Tests] Transaction submission test suite. The initial attempt at testing all authenticators, payloads and argument types Oct 13, 2023

xbtmatt marked this pull request as ready for review October 13, 2023 22:40

xbtmatt requested review from 0xmaayan, 0xmigo, heliuchuan and a team as code owners October 13, 2023 22:40

xbtmatt added 8 commits October 13, 2023 15:47

Beginning of the test suite for transaction submission. Got all publi…

fb9b2ba

…c/private entry functions with all argument types working e2e. Also, changing Object to use fromHexInputRelaxed. Also added FixedBytes to the different argument types.

Fix EntryFunctionArgumentTypes to allow MoveString

4096003

Got all combinations of public/private, single signer, fee payer, and…

397173e

… multi agent tx submission in unit tests

Added sponsored multi agent transaction

0f72fd1

Update test explanation

34774fe

Fmt

c5a6148

Adding comments for a smidgen of readability

5301a2b

Rebasing

fb1f9c2

xbtmatt force-pushed the transaction-arguments branch from 26f9415 to fb1f9c2 Compare October 14, 2023 00:11

gregnazario approved these changes Oct 14, 2023

View reviewed changes

0xmaayan approved these changes Oct 14, 2023

View reviewed changes

gregnazario merged commit 46bb53b into main Oct 14, 2023
5 checks passed

gregnazario deleted the transaction-arguments branch October 14, 2023 03:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tests] Transaction submission test suite. The initial attempt at testing all authenticators, payloads and argument types #34

[Tests] Transaction submission test suite. The initial attempt at testing all authenticators, payloads and argument types #34

xbtmatt commented Oct 12, 2023 •

edited

Loading

gregnazario Oct 12, 2023

xbtmatt Oct 13, 2023

xbtmatt commented Oct 13, 2023

gregnazario left a comment

gregnazario Oct 14, 2023

xbtmatt Oct 14, 2023

gregnazario Oct 14, 2023

gregnazario Oct 14, 2023

gregnazario Oct 14, 2023

xbtmatt Oct 14, 2023 •

edited

Loading

gregnazario Oct 14, 2023

xbtmatt Oct 14, 2023

gregnazario Oct 14, 2023

0xmaayan left a comment

0xmaayan Oct 12, 2023

xbtmatt Oct 14, 2023

0xmaayan Oct 14, 2023

xbtmatt Oct 14, 2023

[Tests] Transaction submission test suite. The initial attempt at testing all authenticators, payloads and argument types #34

[Tests] Transaction submission test suite. The initial attempt at testing all authenticators, payloads and argument types #34

Conversation

xbtmatt commented Oct 12, 2023 • edited Loading

Test suite

Argument types

Authenticators & payloads

Miscellaneous:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xbtmatt commented Oct 13, 2023

gregnazario left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xbtmatt Oct 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xmaayan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xbtmatt commented Oct 12, 2023 •

edited

Loading

xbtmatt Oct 14, 2023 •

edited

Loading