[transaction] Add ability to get transaction hash #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
reviewed
Apr 2, 2024
0xmaayan
approved these changes
Apr 2, 2024
gregnazario
force-pushed
the
add-transaction-hashing
branch
from
9cfd74f to
9ddfaf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ability to get the transaction hash locally.
How it works is that all Rust structs are signed as follows:
APTOS::+StructName=prefixprefix+ BCS encoded bytes of the structNote that, enums are encoded by a u8, followed by the actual bytes associated. So, in the case of the transaction hash, it must be a
UserTransaction= 0 for the enum type before the rest of the bytes.Resolves #321
Note this code, only hashes user transactions
Test Plan
E2E test ensures it's the same as the API
Related Links