-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getChainTopUserTransactions.graphql #35
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering how important this is to be in the SDK?
I'm assuming this is only useful for explorers and statistic sites
@gregnazario Good question. Yeah I don't think this is that much of a P0 query. Shall we revisit the priority on these queries? - https://www.notion.so/aptoslabs/fetch-queries-to-port-over-into-sdk-v2-8a38cf2c47e542e2ae299c900894277b |
c7f4e2a
to
9fc979b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please get these PRs in, and we may think about which queries we need in the future on here.
src/types/generated/operations.ts
Outdated
import * as Types from "./types"; | ||
import * as Types from './types'; | ||
|
||
export type CurrentTokenOwnershipFieldsFragment = { | ||
token_standard: string; | ||
token_properties_mutated_v1?: any | null; | ||
token_data_id: string; | ||
table_type_v1?: string | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this file just disappears?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm wait, which file? or you mean the CurrentTokenOwnershipFieldsFragment
type? I think it got re-formatted
@@ -103,4 +103,12 @@ describe("general api", () => { | |||
|
|||
expect(chainId.ledger_infos[0].chain_id).toBe(2); | |||
}); | |||
|
|||
test("it should fetch chain top user transactions", async () => { | |||
const config = new AptosConfig({ network: Network.TESTNET }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be local
9fc979b
to
6ccc28e
Compare
6ccc28e
to
e17670e
Compare
Description
Add the query getChainTopUserTransactions and e2e test
Test Plan
pnpm test
pnpm fmt
Related Links