Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getChainTopUserTransactions.graphql #35

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

0xmigo
Copy link
Contributor

@0xmigo 0xmigo commented Oct 12, 2023

Description

Add the query getChainTopUserTransactions and e2e test

Test Plan

pnpm test
pnpm fmt

Related Links

Copy link
Contributor Author

0xmigo commented Oct 12, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how important this is to be in the SDK?

I'm assuming this is only useful for explorers and statistic sites

@0xmigo
Copy link
Contributor Author

0xmigo commented Oct 12, 2023

I'm wondering how important this is to be in the SDK?

I'm assuming this is only useful for explorers and statistic sites

@gregnazario Good question. Yeah I don't think this is that much of a P0 query. Shall we revisit the priority on these queries? - https://www.notion.so/aptoslabs/fetch-queries-to-port-over-into-sdk-v2-8a38cf2c47e542e2ae299c900894277b

@0xmigo 0xmigo force-pushed the jin/getChainTopUserTransactions_query branch from c7f4e2a to 9fc979b Compare October 13, 2023 05:27
Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please get these PRs in, and we may think about which queries we need in the future on here.

Comment on lines 1 to 7
import * as Types from "./types";
import * as Types from './types';

export type CurrentTokenOwnershipFieldsFragment = {
token_standard: string;
token_properties_mutated_v1?: any | null;
token_data_id: string;
table_type_v1?: string | null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this file just disappears?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm wait, which file? or you mean the CurrentTokenOwnershipFieldsFragment type? I think it got re-formatted

@@ -103,4 +103,12 @@ describe("general api", () => {

expect(chainId.ledger_infos[0].chain_id).toBe(2);
});

test("it should fetch chain top user transactions", async () => {
const config = new AptosConfig({ network: Network.TESTNET });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be local

@gregnazario gregnazario force-pushed the jin/getChainTopUserTransactions_query branch from 9fc979b to 6ccc28e Compare October 13, 2023 19:08
@gregnazario gregnazario force-pushed the jin/getChainTopUserTransactions_query branch from 6ccc28e to e17670e Compare October 13, 2023 21:42
@gregnazario gregnazario enabled auto-merge (rebase) October 13, 2023 21:42
@gregnazario gregnazario merged commit 3c11946 into main Oct 13, 2023
10 checks passed
@gregnazario gregnazario deleted the jin/getChainTopUserTransactions_query branch October 13, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants