[privatekey] Fix AIP-80 strictness warnings #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
approved these changes
Nov 25, 2024
0xmaayan
approved these changes
Nov 26, 2024
| let formattedPrivateKey = privateKey; | ||
| if (typeof formattedPrivateKey === "string" && formattedPrivateKey.startsWith(aip80Prefix)) { | ||
| // eslint-disable-next-line prefer-destructuring | ||
| formattedPrivateKey = formattedPrivateKey.split("-")[2]; |
There was a problem hiding this comment.
Should we check the length? And if we have an item in index 2?
There was a problem hiding this comment.
I don't want to overdo these functions with logic since its just string manipulation. Its similar to appending secp256k1- and ed25519-. I would prefer that the Ed25519/Secp256k1 classes do the checking when they consume these AIP-80 strings to make sure that they're okay.
Let me know your thoughts here, if you prefer to abstract all the length checking then we could.
There was a problem hiding this comment.
Going to merge for now. We can do the refactor if you have further comments here :)
kaw2k
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Fix AIP-80 strictness warnings * Update changelog --------- Co-authored-by: Greg Nazario <greg@gnazar.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow support for formatting existing AIP-80 strings and remove strictness warnings for bytes.
Test Plan
Related Links
https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-80.md
Checklist
pnpm fmt?CHANGELOG.md?