Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back accidentally deleted deserializeOptionStr and mark deprecated #597

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

heliuchuan
Copy link
Contributor

@heliuchuan heliuchuan commented Nov 27, 2024

Description

This was never meant to be deleted

Checklist

  • Have you ran pnpm fmt?
  • Have you updated the CHANGELOG.md?

@heliuchuan heliuchuan marked this pull request as ready for review November 27, 2024 23:26
@heliuchuan heliuchuan requested a review from a team as a code owner November 27, 2024 23:26
Copy link
Contributor

@GhostWalker562 GhostWalker562 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, make sure to update CHANGELOG

Copy link
Contributor

@hardsetting hardsetting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@heliuchuan heliuchuan merged commit e85364d into main Nov 28, 2024
8 checks passed
@heliuchuan heliuchuan deleted the deprecate branch November 28, 2024 22:39
kaw2k pushed a commit that referenced this pull request Dec 19, 2024
#597)

* Add back function that was supposed to be deprecated

* update deprecated comment

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants