Warn that only devnet has a faucet #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryjrandall
approved these changes
Dec 13, 2024
0xmaayan
approved these changes
Dec 13, 2024
banool
force-pushed
the
banool/warn-devnet-faucet
branch
from
9006355 to
9551946
Compare
|
I just added custom error messages to |
banool
force-pushed
the
banool/warn-devnet-faucet
branch
2 times, most recently
from
97fc235 to
57eb052
Compare
banool
force-pushed
the
banool/warn-devnet-faucet
branch
from
57eb052 to
3ddefa7
Compare
|
The test failure is unrelated, I'm going to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We removed the testnet faucet, we should warn users about this where possible.
It'd be nice to remove testnet and mainnet frrom NetworkToFaucetAPI completely but it seems like that'd be a fairly large change.
Test Plan
Let's see how CI goes.
Related Links
Checklist
pnpm fmt?CHANGELOG.md?