Add transaction submission api test #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
requested review from
gregnazario,
0xmigo,
heliuchuan and
a team
as code owners
0xmaayan
force-pushed
the
generate_transaction_test
branch
from
0e79871 to
f212806
Compare
0xmaayan
force-pushed
the
transaction_submission_test
branch
from
8049a8a to
2f4cffe
Compare
0xmaayan
force-pushed
the
transaction_submission_test
branch
from
2f4cffe to
0f77724
Compare
|
At some point we should probably try to use the same little "test harness" for these lol, there's a ton of setup my transaction arguments test suite looks very similar heh |
xbtmatt
reviewed
Oct 17, 2023
| signer: bob, | ||
| transaction: rawTxn, | ||
|
|
||
| await waitForTransaction({ aptosConfig: config, txnHash: response.hash }); |
There was a problem hiding this comment.
I think in general we should be doing a check here right? for each type
The node api will tell you if you have a fee payer signature, etc
const responseSignature = response.signature as TransactionFeePayerSignature;
expect(responseSignature.type).toEqual("fee_payer_signature");this is what I do in mine
the 5 types:
ed25519_signature
secp256k1_ecdsa_signature
multi_agent_signature
fee_payer_signature
multi_ed25519_signature
There was a problem hiding this comment.
hmm I guess it depends on what you are testing. those tests tests that transaction is submitted. We have some other tests that tests the signature in sign_transaction
xbtmatt
reviewed
Oct 17, 2023
| await fundAccounts(aptos, [ | ||
| senderAccount, | ||
| senderSecp256k1Account, | ||
| ...recieverAccounts, |
There was a problem hiding this comment.
Suggested change
| ...recieverAccounts, | |
| ...receiverAccounts, |
ctrl+f reciever nit :D
0xmaayan
force-pushed
the
transaction_submission_test
branch
from
0f77724 to
a926370
Compare
auto-merge was automatically disabled
October 20, 2023 19:24
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Need #65 to land first.
Add transaction submission api function tests
secp256k1 is skipped for now because of a user txn processor issue #42
Test Plan
pnpm test