Support publish module API #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
requested review from
gregnazario,
0xmigo,
heliuchuan and
a team
as code owners
0xmaayan
force-pushed
the
publish_module
branch
from
204a9e5 to
2e798d8
Compare
0xmigo
approved these changes
Oct 18, 2023
|
|
||
| export async function signAndSubmitTransaction(args: { | ||
| aptosConfig: AptosConfig; | ||
| signer: Account; |
There was a problem hiding this comment.
I like the idea of using Account here. Similar concept to where I would like to replace many address: HexInput to address: AccountAddress :)
There was a problem hiding this comment.
I think we use Account for all transaction submission api functions when the keys are needed
0xmaayan
force-pushed
the
publish_module
branch
from
2e798d8 to
f6cc57a
Compare
0xmaayan
force-pushed
the
publish_module
branch
from
f6cc57a to
d4d81e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an API function to publish a move module with the SDK. It is a used function with some of our external partners.
Note: later, when we will have aptos-cli integrated within the SDK, this process would be much more simple!
Test Plan
pnpm test