Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zellij-org/zellij): disable checksum #6831

Merged
merged 1 commit into from
Oct 5, 2022
Merged

fix(zellij-org/zellij): disable checksum #6831

merged 1 commit into from
Oct 5, 2022

Conversation

suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke commented Oct 5, 2022 •
edited
Loading

The checksum in the checksum file is not the checksum of tarball but the checksum of the executable binary in tarball. aqua doesn't support such a case at the moment.

#6780 (comment)

$ cat zellij-aarch64-apple-darwin.sha256sum 
97acef95ea7d9af2d605adf7947e47aa1130205a4d7b9f61e0c066076fb84a62  zellij

$ sha256sum zellij-aarch64-apple-darwin.tar.gz
620d754f96c40f0227ddff69ef212068a9a5ce62868bc79cdb6d671f6d519fa0  zellij-aarch64-apple-darwin.tar.gz

$ tar xvzf zellij-aarch64-apple-darwin.tar.gz 
x zellij

$ sha256sum zellij
97acef95ea7d9af2d605adf7947e47aa1130205a4d7b9f61e0c066076fb84a62  zellij

@suzuki-shunsuke
fix(zellij-org/zellij): disable checksum
17f0a32 
The checksum in the checksum file is not the checksum of tarball but the checksum of the executable binary in tarball.
aqua doesn't support such a case at the moment.
@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label Oct 5, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v3.68.1 milestone Oct 5, 2022
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Oct 5, 2022
Closed
@suzuki-shunsuke suzuki-shunsuke merged commit d51e760 into main Oct 5, 2022
@suzuki-shunsuke suzuki-shunsuke deleted the fix/zellij-checksum branch October 5, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.69.0
Development

Successfully merging this pull request may close these issues.
1 participant
@suzuki-shunsuke