Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add extraEnv option to Helm chart #2288

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Add extraEnv option to Helm chart #2288

wants to merge 3 commits into from

Conversation

gnadaban
Copy link

Description

This is a small fix to account for the lack of ability to add extra env vars to the trivy-operator deployment.
This allows specifying eg. AWS IAM session names and other options for eg. secret injection.

Related issues

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gnadaban gnadaban changed the title Add extraEnv option to Helm chart fix: Add extraEnv option to Helm chart Oct 21, 2024
@github-actions github-actions bot added the bug label Oct 21, 2024
@github-actions GitHub Actions
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Dec 21, 2024
@afdesk afdesk removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Jan 9, 2025
@simar7 simar7 changed the title fix: Add extraEnv option to Helm chart feat: Add extraEnv option to Helm chart Jan 10, 2025
simar7
simar7 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @afdesk could you take a look as well?

@simar7
Copy link
Member

simar7 commented Jan 10, 2025

@gnadaban could you resolve the merge conflict?

afdesk
afdesk requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnadaban thanks a lot for your contribution! It's really nice.
I left some small comments

deploy/helm/values.yaml Outdated Show resolved Hide resolved
deploy/helm/values.yaml Outdated Show resolved Hide resolved
deploy/helm/values.yaml Outdated Show resolved Hide resolved
deploy/helm/values.yaml Outdated Show resolved Hide resolved
@gnadaban gnadaban force-pushed the add-extra-env-support branch from 7dff68a to ecbbf52 Compare January 10, 2025 14:57
@gnadaban gnadaban requested a review from afdesk January 10, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

@afdesk afdesk Awaiting requested review from afdesk

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for extra env vars in Helm chart
4 participants
@gnadaban @CLAassistant @simar7 @afdesk