Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set initial version to v0.51.1 #6810

Merged
merged 1 commit into from
May 29, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

The release PR shows many commits already included in previous versions. I guess it's because the latest version defined in .release-please-manifest.json is v0.51.4, which is not in the main branch, and Release Please doesn't find it. My somewhat incomplete understanding is that Release Please goes back through the commits until it finds the v0.51.4 commit and, as a result, the release PR includes commits that have already been released.

If my understanding above is correct, the problem should be solved by specifying the tags present in the main commit, so this PR changes the latest version to v0.51.1.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 requested a review from DmitriyLewen May 29, 2024 08:06
@knqyf263 knqyf263 self-assigned this May 29, 2024
@knqyf263 knqyf263 added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@knqyf263 knqyf263 added this pull request to the merge queue May 29, 2024
Merged via the queue into aquasecurity:main with commit fb3c756 May 29, 2024
12 checks passed
@knqyf263 knqyf263 deleted the ci/fix_initial_version branch May 29, 2024 10:04
@knqyf263
Copy link
Collaborator Author

It looks good now.
#6809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants