Skip to content

Commit

Permalink
fix benchmark assertions
Browse files Browse the repository at this point in the history
  • Loading branch information
aMahanna committed Jan 19, 2024
1 parent 16ace5c commit 3f35755
Showing 1 changed file with 18 additions and 4 deletions.
22 changes: 18 additions & 4 deletions benchmark/compare.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,15 @@ def sort_children_by_start_time(children):

def compare_span(master_child: Optional[dict], branch_child: Optional[dict]):
if master_child and branch_child:
assert master_child.get("operationName") == branch_child.get("operationName")
assert master_child.get("tags") == branch_child.get("tags")
assert master_child.get("operationName") == branch_child.get("operationName"), (
f"Master Child Operation Name: {master_child.get('operationName')}\n"
f"Branch Child Operation Name: {branch_child.get('operationName')}"
)

assert master_child.get("tags") == branch_child.get("tags"), (
f"Master Child Tags: {master_child.get('tags')}\n"
f"Branch Child Tags: {branch_child.get('tags')}"
)

operation_name = (
master_child.get("operationName")
Expand Down Expand Up @@ -102,8 +109,15 @@ def compare_children(master_children: list[dict], branch_children: list[dict]):


def compare_traces(master_trace: dict, branch_trace: dict):
assert master_trace.get("operationName") == branch_trace.get("operationName")
assert master_trace.get("tags") == branch_trace.get("tags")
assert master_trace.get("operationName") == branch_trace.get("operationName"), (
f"Master Operation Name: {master_trace.get('operationName')}\n"
f"Branch Operation Name: {branch_trace.get('operationName')}"
)

assert master_trace.get("tags") == branch_trace.get("tags"), (
f"Master Tags: {master_trace.get('tags')}\n"
f"Branch Tags: {branch_trace.get('tags')}"
)

result = {
"operationName": master_trace["operationName"],
Expand Down

0 comments on commit 3f35755

Please sign in to comment.