-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: preserve_adb_keys
in PyG to ArangoDB
#11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this needs to be cleaned up anyway
aMahanna
commented
Aug 3, 2022
aMahanna
commented
Aug 4, 2022
aMahanna
changed the title
do not merge:
new: Aug 4, 2022
preserve_adb_keys
in PyG to ArangoDBpreserve_adb_keys
in PyG to ArangoDB
also minor cleanup
This reverts commit abf477b.
joerg84
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the entry Changelog is missing
No need, as the release.yml action will auto-generate a Changelog entry using commit messages upon triggering a new release (in this case it would be Example: #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warrants a
1.1.0
releaseNote: For notebook testing purposes:
!pip install git+https://github.com/arangoml/pyg-adapter.git@feature/adbpyg-map
instead of!pip install adbpyg-adapter==1.1.0
!git clone -b feature/adbpyg-map --single-branch https://github.com/arangoml/pyg-adapter.git
instead of!git clone -b 1.1.0 --single-branch https://github.com/arangoml/pyg-adapter.git
What's new
Introduces the
preserve_adb_keys
parameter in ArangoDB to PyG. When set toTrue
, will store the ArangoDB vertex & edge_key
values in the (newly created) PyG graph. When calling PyG to ArangoDB, PyG graphs that have a_key
or_id
property will have their vertex & edge IDs persisted. See below for an exampleAdditional Changes
Set[str]
explicit_metagraph=True
, omitted PyG node & edge properties were still being brought over into ArangoDB (this has been fixed)__set_adb_data()
,__set_pyg_data()
pytest_exception_interact
inconftest.py
for post-failure ArangoDB cleanup1.1.0
notebookDemo (
preserve_adb_keys
)Demo (
Set[str]
as a metagraph value)