Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__process_adb_edge_df
method is responsible for creating & appending to anEdgeStorage
'sedge_index
.Part of this code is responsible for mapping the ArangoDB Edges
_from
and_to
values to the ArangoDB Vertex Collection Map (adb_map
) to preserve the zero-based index value associated to the_from
and_to
IDs.For a reason (not yet know), this mapping is returning a Pandas Series of floats instead of integers. These values are then piped into the
edge_index
property, resulting inedge_index.dtype
beingfloat
...This PR aims to address this issue by invoking
astype(int)
after invoking the Pandasmap()
function.astype(int)
on a Pandas Series with possibleNaN
values will raise, so we must also introducefillna(-1)
. This in turn affects the handling of Invalid Edges, hence why that code was also modified