Connect groups to a workspace #905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zak39
added
backend
zak39
force-pushed
the
feature/connexion-to-groups
branch
2 times, most recently
from
803cd80
to
ac2135c
Compare
|
Hi @smarinier :) You don't need this change : ac0e880 . It is already present in the main branch : workspace/.github/workflows/php.yml Lines 15 to 19 in 6a6cbb6 We just need to rebase our branch with the main branch. I could do it if you want 😉 |
zak39
force-pushed
the
feature/connexion-to-groups
branch
from
ac0e880
to
8e73cf5
Compare
zak39
force-pushed
the
feature/connexion-to-groups
branch
from
46731ba
to
273d238
Compare
This commit is not complete yet. It's just a backup and I created SelectConnectedGroups.vue but it's not finish yet. Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
Add the is_ldap key to check if a group is ldap or not. Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
Don't take into account the workspace groups when searching. Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
Take into account the "Restrict users to only share with users in their groups" checkbox and "Ignore the following groups when checking group membership" text input from settings. Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
…end manage its virtuality
We defined the added_groups key on the front-end side and now it's managed on the backend side.
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
- fix @spaceamdinrequired - fix also error message handling in front
This commit is not complete yet. It's just a backup and I created SelectConnectedGroups.vue but it's not finish yet. Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
We defined the added_groups key on the front-end side and now it's managed on the backend side.
Whe return the users list to update the front-end.
…tUsers function When fetching spaces with the findAll function, users from the Workspace Manager group are now included, along with the total number of users in each workspace. Additionally, I created the getUsers function to retrieve users related to a specific workspace.
We have implemented the IBootstrap interface in the Application class. This means that Middleware is registered differently, and the destroy() method in the WorkspaceController could not work without this change.
zak39
force-pushed
the
feature/connexion-to-groups
branch
from
6f77dd8
to
71bb9bc
Compare
added 13 commits
November 13, 2024 15:39
When we search for "HR", we don't get the HR group. Now, it's fixed! The search function returns an array with "groups" and "exact" keys. The exact group can be found in the "exact" key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a draft for the moment.
OP#3293