Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize space filling curve checks #1002

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Modernize space filling curve checks #1002

merged 1 commit into from
Dec 29, 2023

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Dec 28, 2023 •
edited
Loading

Following the ideas of #1001.

dalg24
dalg24 requested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same deal here #939 introduced a bug and a space filling curve that is missing the const qualifier on the call operator would be erroneously validated.

src/details/ArborX_SpaceFillingCurves.hpp Outdated Show resolved Hide resolved
src/details/ArborX_SpaceFillingCurves.hpp Outdated Show resolved Hide resolved
@aprokop aprokop added the refactoring Code reorganization label Dec 28, 2023
@aprokop aprokop merged commit 0f24a37 into arborx:master Dec 29, 2023
1 of 2 checks passed
@aprokop aprokop deleted the cleanup_space_filling_curve branch December 29, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
refactoring Code reorganization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprokop @dalg24