Add upper_bound kernel #1170
Merged
Add upper_bound kernel #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Oct 4, 2024
| Kokkos::View<float *, Kokkos::HostSpace, | ||
| Kokkos::MemoryTraits<Kokkos::Unmanaged>>(v_ref.data(), n)); | ||
| Kokkos::View<float *, DeviceType> v("Testing::v", n); | ||
| Kokkos::deep_copy(space, v, UnmanagedView<float>(v_ref.data(), n)); |
There was a problem hiding this comment.
Why do we care to copy with a specific exec space if we constructed the view without it?
Can't just use create_mirror_view_and_copy() ?
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
aprokop
force-pushed
the
upper_bound_kernel
branch
from
cc99046
to
4d6da22
Compare
|
Addressed the comments, and rebased on |
dalg24
approved these changes
Oct 8, 2024
| space, v, | ||
| Kokkos::View<float *, Kokkos::HostSpace, | ||
| Kokkos::MemoryTraits<Kokkos::Unmanaged>>(v_ref.data(), n)); | ||
| Kokkos::View<float *, DeviceType> v("Testing::v", 0); |
There was a problem hiding this comment.
I thought we were going for "[ArborX]{Test,Example}::foo"
There was a problem hiding this comment.
We use "Testing::foo" and "Example::foo". We use ArborXTest namespaces.
There was a problem hiding this comment.
Please Testing (does not need to be resolved here
There was a problem hiding this comment.
Please Test
ing(does not need to be resolved here
Are you asking to change all Testing:: to Test:: in a separate PR? Or to ArborXTest::?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KokkosExt::upper_boundkernel and testsArborX_Test_DetailsUtils