Fiddle with return type deduction for Point and Sphere centroid algorithm to prefer references #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
force-pushed
the
fix_couple_centroid
branch
from
49ca814
to
f86393b
Compare
dalg24
changed the title
dalg24
approved these changes
Oct 10, 2024
| @@ -40,7 +40,7 @@ using namespace GeometryTraits; | |||
| template <typename Point> | |||
| struct centroid<PointTag, Point> | |||
| { | |||
| KOKKOS_FUNCTION static constexpr auto apply(Point const &point) | |||
| KOKKOS_FUNCTION static constexpr auto &apply(Point const &point) | |||
There was a problem hiding this comment.
Suggested change
| KOKKOS_FUNCTION static constexpr auto &apply(Point const &point) | |
| KOKKOS_FUNCTION static constexpr Point &apply(Point const &point) |
There was a problem hiding this comment.
I did not see how it made any difference. Minor clarity, perhaps.
There was a problem hiding this comment.
Then say so, don't just ignore suggestions.
Otherwise I will quit approving ahead of time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.